Releasing new charts version for v1.18.1 #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
reviewed
May 15, 2024
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v1 | |||
| name: aws-vpc-cni | |||
| version: 1.18.1 | |||
| version: 1.3.0 | |||
There was a problem hiding this comment.
Why is this 1.3.0? https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/aws-vpc-cni/Chart.yaml#L3 seems like we are matching the release version.
There was a problem hiding this comment.
Right, but it would fail if I keep it 1.18.1.. We have kept it different in the past
eks/aws-vpc-cni 1.13.0 v1.13.0 A Helm chart for the AWS VPC CNI
eks/aws-vpc-cni 1.2.8 v1.12.6 A Helm chart for the AWS VPC CNI
eks/aws-vpc-cni 1.2.7 v1.12.5 A Helm chart for the AWS VPC CNI
eks/aws-vpc-cni 1.2.6 v1.12.2 A Helm chart for the AWS VPC CNI
eks/aws-vpc-cni 1.2.2 v1.12.1 A Helm chart for the AWS VPC CNI
There was a problem hiding this comment.
yeah it looks odd, sure we can have it 1.3.0 for now given that we will have another release in few weeks
jayanthvn
approved these changes
May 17, 2024
|
👋🏻 ping. (Can this be merged?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description of changes
This update the chart version for v1.18.1 and adds the
FileOrCreatetype for xtables-lock volumeChecklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.