Add support for spire-controller-manager to appmesh-spire-server #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardXF
reviewed
Feb 23, 2023
| @@ -42,9 +42,18 @@ rbac: | |||
| # rbac.create: `true` if rbac resources should be created | |||
| create: true | |||
|
|
|||
| spireControllerManager: | |||
| enabled: true | |||
There was a problem hiding this comment.
This default value should be set to false
EdwardXF
reviewed
Feb 23, 2023
| repository: ghcr.io/spiffe/spire-controller-manager | ||
| tag: 0.2.1 | ||
| pullPolicy: IfNotPresent | ||
| ignoreNamespaces: [ kube-system, kube-public, spire ] |
There was a problem hiding this comment.
The appmesh-system namespace should be also ignored
|
I noticed that this controller is still in pre-prod stage. We cannot approve this PR for now due to security concerns but thanks for contributing! |
|
Makes sense, I'll keep an eye on that project if they ever move it into prod. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
appmesh-spire-server #895
Description of changes
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Installed helm chart to my local cluster to verify spire-server and spire-controller-manager both work in tandem
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.