Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes attribution retry logic #1214

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Oct 15, 2023

Issue #, if available:

Description of changes:

We will occasionally see timeouts when requesting the go-import url. This code has largely been unchanged for 2 years, but turns out the retry logic was just wrong and when the timeouts would occur, they would sometimes result in uncaught exceptions. This looks like a big change, but for the most part its just changing the old promise still methods to better utilize async/await and actually work in terms of retrying.

Since I was here, went ahead and updated the dependencies and updated some of the expected output files due to changes in upstream repo names.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jaxesn
Copy link
Member Author

jaxesn commented Oct 16, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaxesn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit ad73b4a into aws:main Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants