Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ansible collections needed for image builds #1217

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Oct 18, 2023

Issue #, if available:

Description of changes:

This is something the eks-a image builder requires which has for all this time been downloaded at build time. This upstream endpoint will go down from time to time, breaking builds unnecessarily. Baking these in will help with stability.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jaxesn jaxesn force-pushed the jgw/add-ansible-collections branch from 6a7513a to 61e352a Compare October 18, 2023 21:24
@zafs23
Copy link
Contributor

zafs23 commented Oct 27, 2023

/lgtm

@jaxesn
Copy link
Member Author

jaxesn commented Oct 27, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaxesn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 4fcb8b7 into aws:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants