Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with common mac os find #1284

Closed
wants to merge 2 commits into from

Conversation

rcrozean
Copy link
Member

Issue #, if available:

Description of changes:
Add a common function like aws/eks-anywhere-build-tooling@e24cd14#diff-a5ed650d97e91497a26f14a346a388676aba4e377ea1efff495154c860b3171b to find local commands for macOS.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rcrozean. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added minimal-image Changes related to the minimal-images or tooling builder-base labels Dec 12, 2023
@eks-distro-bot
Copy link
Collaborator

@rcrozean: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-distro-base-test-presubmit 220e183 link true /test eks-distro-base-test-presubmit
builder-base-tooling-presubmit-al-2023 220e183 link true /test builder-base-tooling-presubmit-al-2023
builder-base-tooling-presubmit-al-2 220e183 link true /test builder-base-tooling-presubmit-al-2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -19,29 +19,32 @@ set -o pipefail
SCRIPT_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
source $SCRIPT_ROOT/common_vars.sh

BASE_DIRECTORY="$(git rev-parse --show-toplevel)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id probably skip this file since youll need to change the dockerfile for all the layers to include the new common.sh file.

@rcrozean rcrozean closed this Apr 9, 2024
@rcrozean rcrozean deleted the updateWithCommonMacOSFind branch April 9, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder-base minimal-image Changes related to the minimal-images or tooling size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants