Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage test; point minimal build version to Go 1.22 #1588

Closed
wants to merge 1 commit into from

Conversation

natechensan
Copy link
Member

Issue #, if available:
Test coverage was failing because it was looking for crypto/ecdh in 1.19, which it doesn't exist.

Description of changes:
Point the minimal versions in the build process to Go 1.22.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from natechensan. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the minimal-image Changes related to the minimal-images or tooling label Jan 2, 2025
@eks-distro-bot
Copy link
Collaborator

@natechensan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
prow-plugin-tooling-presubmit 67d42a1 link true /test prow-plugin-tooling-presubmit
eks-distro-release-tooling-presubmit 67d42a1 link true /test eks-distro-release-tooling-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@natechensan natechensan closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minimal-image Changes related to the minimal-images or tooling size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants