Use constant for “types”

aws · Dec 4, 2024 · 0c94baf · 0c94baf
1 parent 0698768
commit 0c94baf
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 9 deletions.
diff --git a/packages/graph-explorer/src/core/StateProvider/configuration.ts b/packages/graph-explorer/src/core/StateProvider/configuration.ts
@@ -17,7 +17,10 @@ import {
   VertexPreferences,
 } from "./userPreferences";
 import isDefaultValue from "./isDefaultValue";
-import { RESERVED_ID_PROPERTY } from "@/utils/constants";
+import {
+  RESERVED_ID_PROPERTY,
+  RESERVED_TYPES_PROPERTY,
+} from "@/utils/constants";
 
 export const isStoreLoadedAtom = atom<boolean>({
   key: "store-loaded",
@@ -243,7 +246,7 @@ export const edgeTypesSelector = selector({
 export const defaultVertexTypeConfig = {
   attributes: [],
   displayNameAttribute: RESERVED_ID_PROPERTY,
-  longDisplayNameAttribute: "types",
+  longDisplayNameAttribute: RESERVED_TYPES_PROPERTY,
   color: "#128EE5",
   iconUrl: DEFAULT_ICON_URL,
   iconImageType: "image/svg+xml",

diff --git a/packages/graph-explorer/src/core/StateProvider/displayVertex.ts b/packages/graph-explorer/src/core/StateProvider/displayVertex.ts
@@ -11,7 +11,11 @@ import {
   DisplayVertexTypeConfig,
   displayVertexTypeConfigSelector,
 } from "./displayTypeConfigs";
-import { MISSING_DISPLAY_VALUE, RESERVED_ID_PROPERTY } from "@/utils/constants";
+import {
+  MISSING_DISPLAY_VALUE,
+  RESERVED_ID_PROPERTY,
+  RESERVED_TYPES_PROPERTY,
+} from "@/utils/constants";
 import { queryEngineSelector } from "../connector";
 
 /** Represents a vertex's display information after all transformations have been applied. */
@@ -97,7 +101,7 @@ const displayVertexSelector = selectorFamily({
       function getDisplayAttributeValueByName(name: string | undefined) {
         if (name === RESERVED_ID_PROPERTY) {
           return displayId;
-        } else if (name === "types") {
+        } else if (name === RESERVED_TYPES_PROPERTY) {
           return displayTypes;
         } else if (name) {
           return (

diff --git a/packages/graph-explorer/src/modules/EntityDetails/NodeDetail.tsx b/packages/graph-explorer/src/modules/EntityDetails/NodeDetail.tsx
@@ -3,7 +3,10 @@ import useTranslations from "@/hooks/useTranslations";
 import NeighborsList from "@/modules/common/NeighborsList/NeighborsList";
 import EntityAttribute from "./EntityAttribute";
 import defaultStyles from "./EntityDetail.styles";
-import { RESERVED_ID_PROPERTY } from "@/utils/constants";
+import {
+  RESERVED_ID_PROPERTY,
+  RESERVED_TYPES_PROPERTY,
+} from "@/utils/constants";
 import { VertexRow } from "@/components";
 
 export type VertexDetailProps = {
@@ -32,7 +35,7 @@ export default function NodeDetail({ node }: VertexDetailProps) {
           />
           <EntityAttribute
             attribute={{
-              name: "types",
+              name: RESERVED_TYPES_PROPERTY,
               displayLabel: t("node-detail.node-type"),
               displayValue: node.displayTypes,
             }}

diff --git a/packages/graph-explorer/src/modules/NodesStyling/SingleNodeStyling.tsx b/packages/graph-explorer/src/modules/NodesStyling/SingleNodeStyling.tsx
@@ -28,7 +28,10 @@ import modalDefaultStyles from "./SingleNodeStylingModal.style";
 import { useVertexTypeConfig } from "@/core/ConfigurationProvider/useConfiguration";
 import { useDebounceValue, usePrevious } from "@/hooks";
 import { cn } from "@/utils";
-import { RESERVED_ID_PROPERTY } from "@/utils/constants";
+import {
+  RESERVED_ID_PROPERTY,
+  RESERVED_TYPES_PROPERTY,
+} from "@/utils/constants";
 
 export type SingleNodeStylingProps = {
   vertexType: string;
@@ -73,7 +76,7 @@ export default function SingleNodeStyling({
 
     options.unshift({
       label: t("nodes-styling.node-type"),
-      value: "types",
+      value: RESERVED_TYPES_PROPERTY,
     });
     options.unshift({
       label: t("nodes-styling.node-id"),

diff --git a/packages/graph-explorer/src/utils/constants.ts b/packages/graph-explorer/src/utils/constants.ts
@@ -6,6 +6,9 @@ export const DEFAULT_CONCURRENT_REQUESTS_LIMIT = 10;
 /** The name of the special property representing the node ID */
 export const RESERVED_ID_PROPERTY = "~id";
 
+/** The name of the property representing the list of types of the node */
+export const RESERVED_TYPES_PROPERTY = "types";
+
 /** The string "Graph Explorer". */
 export const APP_NAME = "Graph Explorer";
 

diff --git a/packages/graph-explorer/src/workspaces/DataExplorer/DataExplorer.tsx b/packages/graph-explorer/src/workspaces/DataExplorer/DataExplorer.tsx
@@ -58,6 +58,7 @@ import {
   APP_NAME,
   MISSING_DISPLAY_VALUE,
   RESERVED_ID_PROPERTY,
+  RESERVED_TYPES_PROPERTY,
 } from "@/utils/constants";
 
 export type ConnectionsProps = {
@@ -202,7 +203,7 @@ function DisplayNameAndDescriptionOptions({
 
     options.unshift({
       label: t("data-explorer.node-type"),
-      value: "types",
+      value: RESERVED_TYPES_PROPERTY,
     });
     options.unshift({
       label: t("data-explorer.node-id"),