Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated styles(info-bar), updated component to add new Re-Sync column… #120

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

cubeddu
Copy link
Contributor

@cubeddu cubeddu commented Jun 20, 2023

Issue #98

Description of changes:

This PR addresses the feature request to make the synchronization button more prominent by increasing the size of the icon. The current icon size is small and this PR increases it to large. This change will make it easier for users to locate and use the synchronization button.

In addition, created a Re-Sync column to the info-bar div to make it a prominent placement. This will provide users with a clear indication of the synchronization status and allow them to easily initiate a re-sync if necessary.

Furthermore, updated the CSS styles from flex-start to space-between. This change will improve the layout of the info-bar div and provide better spacing between the different elements.

Before:
Screenshot 2023-06-20 at 6 35 26 PM

After:
Screenshot 2023-06-20 at 6 08 04 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joywa joywa requested a review from agutierrezgit June 21, 2023 16:54
@agutierrezgit
Copy link
Contributor

@cubeddu thanks for your suggestion.
We need to consider the potential issue of items getting too separated on larger screens if we let the items space themselves up to the full width. We recommend keeping the content on the left side.

We also recommend moving the sync button to the global actions in the header showing a tooltip on hover. This way, it remains easily accessible to users while maintaining a consistent layout across different screen sizes. See picture below.

Captura de pantalla 2023-06-27 a las 9 51 56

If you think it should be more prominent to the user we can go with a full button.

Captura de pantalla 2023-06-27 a las 9 47 27

Copy link
Contributor

@agutierrezgit agutierrezgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are ok but design can be improved. See my comment in the main thread Thanks

@cubeddu
Copy link
Contributor Author

cubeddu commented Jun 29, 2023

@agutierrezgit
I agree with your recommendation, and I have made the necessary changes for a second review. Thank you for your help.

image

Copy link
Contributor

@agutierrezgit agutierrezgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubeddu Thanks for the quick turnaround. If you can add these small changes this will be ready to go.

@cubeddu
Copy link
Contributor Author

cubeddu commented Jun 30, 2023

Hey @agutierrezgit
Changes have been pushed up.

Thanks

Copy link
Contributor

@agutierrezgit agutierrezgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cubeddu ! @joywa I tested the changes and the PR is ready for approval and merge.

@alexey-temnikov alexey-temnikov merged commit dc3d14f into aws:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants