-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated styles(info-bar), updated component to add new Re-Sync column… #120
Conversation
@cubeddu thanks for your suggestion. We also recommend moving the sync button to the global actions in the header showing a tooltip on hover. This way, it remains easily accessible to users while maintaining a consistent layout across different screen sizes. See picture below. If you think it should be more prominent to the user we can go with a full button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are ok but design can be improved. See my comment in the main thread Thanks
@agutierrezgit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cubeddu Thanks for the quick turnaround. If you can add these small changes this will be ready to go.
packages/graph-explorer/src/modules/ConnectionDetail/ConnectionDetail.tsx
Outdated
Show resolved
Hide resolved
packages/graph-explorer/src/modules/ConnectionDetail/ConnectionDetail.tsx
Outdated
Show resolved
Hide resolved
Hey @agutierrezgit Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #98
Description of changes:
This PR addresses the feature request to make the synchronization button more prominent by increasing the size of the icon. The current icon size is
small
and this PR increases it tolarge
. This change will make it easier for users to locate and use the synchronization button.In addition, created a Re-Sync column to the info-bar div to make it a prominent placement. This will provide users with a clear indication of the synchronization status and allow them to easily initiate a re-sync if necessary.
Furthermore, updated the CSS styles from
flex-start
tospace-between
. This change will improve the layout of the info-bar div and provide better spacing between the different elements.Before:
After:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.