Feat/hook tests #130
Merged
Feat/hook tests #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d updated useEntities.test.ts
|
@agutierrezgit Thank you for your feedback. I went ahead and made the necessary updates. I am now ready for review. |
This commit does the following: - Configures Jest to generate coverage reports in the directory. - Adds as a Jest reporter to generate JUnit-formatted test results, improving CI visibility. - Updates the GitHub Actions workflow to upload coverage reports to Codecov, sourced only from the directory. - Adds generated coverage reports and JUnit test results to to prevent them from being committed to the repository.
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
======================================
Coverage ? 9.09%
======================================
Files ? 444
Lines ? 29697
Branches ? 208
======================================
Hits ? 2701
Misses ? 26990
Partials ? 6 |
Co-authored-by: Alexey Temnikov <[email protected]>
Co-authored-by: Alexey Temnikov <[email protected]>
alexey-temnikov
previously approved these changes
Jul 20, 2023
Co-authored-by: Alexey Temnikov <[email protected]>
alexey-temnikov
previously approved these changes
Jul 20, 2023
alexey-temnikov
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test cases in the
graph-explorerpackage:isErrorResponsein packages/graph-explorer/src/connector/utils/isErrorResponse.test.tsuseEntitiesin packages/graph-explorer/src/hooks/useEntities.test.tsuseEntitiesCountsin packages/graph-explorer/src/hooks/useEntitiesCounts.test.tsuseNeighborsOptionsin packages/graph-explorer/src/hooks/useNeighborsOptions.test.tsusePreviousin packages/graph-explorer/src/hooks/usePrevious.test.tsuseTextTransformin packages/graph-explorer/src/hooks/useTextTransform.test.tsMotivation
Adding tests ensures the stability and reliability of the hooks in the
graph-explorerpackage. It helps identify any potential bugs or issues before they impact the functionality of the application.Changes Made
Test cases have been written for each hook mentioned above. These test cases cover various scenarios and edge cases to validate the correct behavior of the hooks.
Testing
The added test cases have been executed and pass successfully.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.