-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling #283
Conversation
7fe4b1c
to
ac6a0dc
Compare
ac6a0dc
to
1bc5ad9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 12.02% 12.15% +0.13%
==========================================
Files 410 411 +1
Lines 30481 30575 +94
Branches 764 776 +12
==========================================
+ Hits 3665 3717 +52
- Misses 26483 26525 +42
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1bc5ad9
to
2849d14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kmcginnes ! This should substantially improve user debugging.
Description
Improves the error handling within Graph Explorer and the proxy server in various ways.
Client Side Changes
createDisplayError()
function to map errors to friendly errors that can be displayed to the user (this will grow over time)createDisplayError()
in schema sync and keyword searchresponse.ok
for anyuseGEFetch()
requests and throw an error if it is notServer Side Changes
app.use(errorHandler)
Validation
Schema sync failure (connection refused)
Fetch timeout
Neptune long query server timeout
Related Issues
Fixes issue #275
Check List
pnpm run checks
to ensure code compiles and meets standards.pnpm run test
to check if all tests are passing.