Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PNPM mono repo setup #305

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Fix PNPM mono repo setup #305

merged 11 commits into from
Apr 29, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Apr 16, 2024

Description

Moves all repo related activities to the root folder.

Before, you had to open VS Code in the /packages/graph-explorer folder, or the /packages/graph-explorer-proxy-server folder. If you needed both you just had to jump around in different windows. If you tried to open the root folder in VS Code then Prettier & ESLint would not work. Also, managing dependencies was confusing because there were PNPM lock files in the root and each package folder.

Validation

  • Open VS Code at the root and ensure Prettier and ESLint work
  • Run pnpm start for development
  • Read through documentation changes
  • Open a test file and run Jest Current File task
  • Run docker build . to ensure Docker build succeeds

Related Issues

Addresses #303

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm run checks to ensure code compiles and meets standards.
  • I have run pnpm run test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@kmcginnes
Copy link
Collaborator Author

kmcginnes commented Apr 16, 2024

Updating to Node v20 is the next step. This will align our requirement to use CorePack, which requires at least v18. But it is a bigger change requiring testing of the Docker containers and Notebooks.

@kmcginnes
Copy link
Collaborator Author

Updated to include the fix from #306 and update it to the newer PNPM version

@kmcginnes
Copy link
Collaborator Author

Updated

  • Removed the Node version change since that is the focus of the next PR
  • Updated pnpm checks to be better and faster using PNPM's concurrent commands support
  • Add /.github/**/** to .prettierignore since there was a warning that we can fix in a follow up PR since this PR is so large already.

Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmcginnes kmcginnes merged commit b39a09c into aws:main Apr 29, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-pnpm branch April 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants