-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PNPM mono repo setup #305
Conversation
Updating to Node v20 is the next step. This will align our requirement to use CorePack, which requires at least v18. But it is a bigger change requiring testing of the Docker containers and Notebooks. |
Updated to include the fix from #306 and update it to the newer PNPM version |
5a2a3be
to
3db4eb5
Compare
Updated
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Moves all repo related activities to the root folder.
Before, you had to open VS Code in the
/packages/graph-explorer
folder, or the/packages/graph-explorer-proxy-server
folder. If you needed both you just had to jump around in different windows. If you tried to open the root folder in VS Code then Prettier & ESLint would not work. Also, managing dependencies was confusing because there were PNPM lock files in the root and each package folder.Validation
pnpm start
for developmentdocker build .
to ensure Docker build succeedsRelated Issues
Addresses #303
Check List
pnpm run checks
to ensure code compiles and meets standards.pnpm run test
to check if all tests are passing.