Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure attributes are updated in schema when entities are updated #356

Merged
merged 2 commits into from
May 8, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented May 7, 2024

Description

When entities are updated the logic in the setter was adding any node or edge types that were missing in the schema.

I've extended that logic to also add any attributes that are missing to the schema.

Validation

Node testing

  1. Add node to graph
  2. Take note of existing attributes on node in details pane
  3. Add property to node
    g.V({Node ID}).property("added-prop", 123)
    
  4. Clear graph
  5. Add same node to graph
  6. Notice new property in details pane

Edge testing

  1. Add node to graph
  2. Expand node and select edge
  3. Take note of existing attributes on edge in details pane
  4. Add property to edge
    g.E({Edge ID}).property("added-prop", 123)
    
  5. Clear graph
  6. Add same node to graph
  7. Expand
  8. Select edge
  9. Notice new property in details pane

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@kmcginnes kmcginnes requested a review from vkagamlyk May 7, 2024 23:05
@kmcginnes kmcginnes marked this pull request as ready for review May 7, 2024 23:05
Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love schema update without bothering server!

@kmcginnes kmcginnes merged commit afb4b83 into aws:main May 8, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-edge-prop-update branch May 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement node & edge property updating [Bug] Newly added edge properties are not reflected by the Explorer
2 participants