Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "accept" header to requests from proxy server #395

Merged
merged 2 commits into from
May 14, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented May 14, 2024

The proxy server always assumes a response in JSON format, but that is not always the default response type.

This change makes it explicit that we want a JSON response by adding it to the headers:

headers: {
  "Content-Type": "application/x-www-form-urlencoded",
  "Accept": "application/json"
},

Validation

Screenshot 2024-05-14 at 3 01 31 PM

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

Copy link
Contributor

@cubeddu cubeddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmcginnes kmcginnes marked this pull request as ready for review May 14, 2024 20:17
@kmcginnes kmcginnes merged commit b98c09c into aws:main May 14, 2024
1 check passed
@kmcginnes kmcginnes deleted the add-accept-header branch May 14, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SPARQL access to queryid header leads failed search
3 participants