Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display GraphExplorer version in client UI #46

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

nestoralvarezd
Copy link
Contributor

Issue 77

Description of changes:

  • Display the version number in the top bar of all workspaces.
  • The version number is extracted from the package.json version number and injected into the application through the GRAPH_EXP_VERSION variable, which can be globally accessed by the application components.

@joywa joywa self-requested a review February 3, 2023 20:42
@joywa
Copy link
Contributor

joywa commented Feb 3, 2023

Can we remove the "V" from this? I think it looks cleaner without. Let's also add some "Release" documentation on what exactly needs to be changed in which files when we are ready to increment the release number: https://github.com/aws/graph-explorer/blob/main/additionaldocs/development.md

@nestoralvarezd nestoralvarezd force-pushed the feature/77-display-version branch from 02f60f0 to 320bd7c Compare February 9, 2023 17:32
@nestoralvarezd nestoralvarezd force-pushed the feature/77-display-version branch from 320bd7c to fe92f29 Compare February 9, 2023 17:38
@joywa joywa requested a review from michaelnchin February 10, 2023 07:43
@joywa
Copy link
Contributor

joywa commented Feb 10, 2023

Looks good to me. Adding @michaelnchin for one more review. Let's merge this last, when we're ready to release.

Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM, thanks!

@joywa joywa added this to the Release 1.1.0 milestone Feb 15, 2023
@joywa joywa merged commit 295d8a0 into aws:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants