Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand cleanup & progress UI #463

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Expand cleanup & progress UI #463

merged 7 commits into from
Jun 26, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 26, 2024 •
edited
Loading

Description

  • Updates label of the "Show More" toggle button in the neighbors list
  • Better handling of props in the LoadingSpinner component
  • Move to new file and rename useUpdateNodeCounts()
  • Add new related hook that focuses on a single node useUpdateNodeCountsQuery()
  • Use the hook to get progress and error info about the node counts query

Validation

CleanShot 2024-06-26 at 18 25 04@2x

CleanShot 2024-06-26 at 18 31 46@2x

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review June 26, 2024 23:32
@kmcginnes kmcginnes requested a review from vkagamlyk June 26, 2024 23:33
@kmcginnes kmcginnes merged commit bfd1e56 into aws:main Jun 26, 2024
1 check passed
@kmcginnes kmcginnes deleted the expand-cleanup branch June 26, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkagamlyk vkagamlyk vkagamlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Add spinner and error state to sidebar for expansion and node counts
2 participants
@kmcginnes @vkagamlyk