Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send queryId when using proxy server #529

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Aug 1, 2024

Description

We put the queryId in the headers for Gremlin and SPARQL requests so they can be cancelled by the proxy server. But some database endpoints will report CORS issues if the header contains unexpected values.

If we are not using the proxy server then there is no reason to have the queryId in the headers.

Validation

  • Tested against Neptune
  • Tested against https://id.nlm.nih.gov/mesh (SPARQL)

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review August 1, 2024 21:28
@kmcginnes kmcginnes requested a review from vkagamlyk August 1, 2024 21:29
@kmcginnes kmcginnes merged commit 79aa7f0 into aws:main Aug 1, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-cors-error-no-proxy branch August 1, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS violation when not using proxy
2 participants