Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TypeScript config #558

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Aug 27, 2024

Description

  • Run Node server in production mode
  • Add root level tsconfig.json for better type checking performance in VS Code
  • Add base tsconfig.base.json that all other configs will extend
    • Fix code that had lint errors from new TypeScript strictness
  • Ignore incremental build file
  • More thorough clean and build for proxy server

Validation

  • Verified CLI commands
  • Verified production build

Related Issues

  • None

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review August 27, 2024 03:10
@kmcginnes kmcginnes force-pushed the stricter-type-checking branch from 7d21021 to c6f6001 Compare August 27, 2024 17:10
@kmcginnes kmcginnes marked this pull request as draft August 27, 2024 22:33
@kmcginnes kmcginnes force-pushed the stricter-type-checking branch from 492b3b3 to 26cb83c Compare August 27, 2024 23:51
@kmcginnes
Copy link
Collaborator Author

Updated to fix type checking and add clean to the pnpm checks step. The clean is to make sure the checks does not perform an incremental build. This makes sure we see all errors.

@kmcginnes kmcginnes requested a review from michaelnchin August 27, 2024 23:52
@kmcginnes kmcginnes marked this pull request as ready for review August 27, 2024 23:52
@kmcginnes kmcginnes merged commit 0e23a46 into aws:main Aug 28, 2024
1 check passed
@kmcginnes kmcginnes deleted the stricter-type-checking branch August 28, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants