Moving self-signed SSL cert creation to docker entrypoint script. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnchin
previously approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Tested and verified functionality. Looks good, thanks @triggan !
…ker-entrypoint-script
michaelnchin
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Removed self-signed SSL cert creation from Dockerfile and created a new entrypoint script for certs to be created when the container is launched. This removes the need for a user to build a new container image for each deployment and allows them to set the hostname used by the SSL cert upon launching the container using a
HOSTenvironment variable.Updated README.md to include the updated steps for container image build and launching a new container. Also added a new Troubleshooting section to address common issues seen by users attempting to launch graph-explorer.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.