Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove development and documentation related files from Docker image #613

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Sep 13, 2024

Description

  • Removes package write permissions from Docker image workflow
  • Updates .dockerignore file to exclude development files and documentation

Validation

  • Built and loaded Docker container to ensure .git folder and other dev and doc files were not present
  • Verify docker image still runs Graph Explorer fine

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review September 13, 2024 18:22
@kmcginnes kmcginnes merged commit 88ae0c8 into aws:main Sep 13, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-security-issue branch September 13, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants