Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidebar style #651

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Update sidebar style #651

merged 3 commits into from
Oct 29, 2024

Conversation

kmcginnes
Copy link
Collaborator

Description

Updates the visual style of the sidebar buttons, and simplifies the code a bit.

  • Remove unnecessary components that were overly generic
  • Use Radix UI for the toggle primitive
  • Use tailwind for the styles
  • Consolidate primary brand colors as HSL values in CSS with new shades of all standard tailwind values (brand-300 is light, brand-500 is main, brand-800 is dark)
  • Use CSS color-mix() for the fade() function which moves the opacity logic out of JS and in to CSS, which is compatible with the HSL colors

Validation

Preview Video

CleanShot.2024-10-28.at.17.28.06.mp4

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review October 28, 2024 22:51
@kmcginnes kmcginnes merged commit 50501e1 into aws:main Oct 29, 2024
1 check passed
@kmcginnes kmcginnes deleted the style-sidebar branch October 29, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants