Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing transition to Tailwind #657

Merged
merged 12 commits into from
Nov 5, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Nov 4, 2024

Description

This PR continues the transition to Tailwind. It also has a couple of small fixes.

  • Fixes search result detail vertical scrolling
  • Allows clicking anywhere on a connection row to make it active
  • Installs Class Variance Authority (cva) which allows style variants based on props using Tailwind
  • Adds existing zIndex named values to Tailwind config
  • Remove use of AdvancedList for connection rows
    • The AdvancedList component is one of the most complicated components in Graph Explorer. This is the first step in reducing the dependence on it so I can either remove it entirely or vastly simplify it.
  • Remove unused badge logic from IconButton
    • Was previously used by SidebarButton, but that no longer uses IconButton
  • Use Tailwind styles for Chip, VertexHeader, Legend, PanelEmptyState, and some other random one off places
  • Set root font size in VS Code Tailwind extension so that the tooltips show the proper pixel calculation for rem units
  • Fix types in AdvancedList to utilize the generics properly
  • Remove aria-hidden in the badge part of SidebarButton that was causing a browser console error

Validation

  • Validated that the app still functions as before
  • Specifically focused on the available connections functionality since that was replaced

Related Issues

  • None (tech debt)

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes force-pushed the tailwind-styles branch 2 times, most recently from 8234170 to 08158de Compare November 4, 2024 17:43
@kmcginnes kmcginnes marked this pull request as ready for review November 4, 2024 23:51
michaelnchin
michaelnchin previously approved these changes Nov 5, 2024
@kmcginnes kmcginnes merged commit e364bef into aws:main Nov 5, 2024
1 check passed
@kmcginnes kmcginnes deleted the tailwind-styles branch November 5, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants