Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify IconButton to not use react-aria #683

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

Description

This continues tech debt work to move over to Radix and more standard APIs for our components.

  • Removes as capability from IconButton since it was used in a single place
    • The single use of as did not seem to have any impact after it was removed
  • Update callers to use standard button API for disabled and onClick

Validation

  • Verified all select drop down look and behave correctly
  • Verify IconButtons continue to work properly

Related Issues

  • None (tech debt)

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review November 25, 2024 19:03
@kmcginnes kmcginnes merged commit 638b70f into aws:main Nov 26, 2024
1 check passed
@kmcginnes kmcginnes deleted the icon-button branch November 26, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants