Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning Tailwind and old EmotionCSS themes #777

Merged
merged 15 commits into from
Feb 5, 2025

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Feb 3, 2025

Description

  • Uses colors defined in CSS variables for EmotionCSS styles
  • Use Tailwind's stock neutral gray colors for the grays in the theme
  • Tweak the grays for borders and backgrounds to soften them
  • Tweak the background color of sidebar tab items
  • Remove custom shadows from old theme to rely on stock Tailwind shadows
  • Remove Card and use inline styles (each use was slightly unique anyway)
  • Use Panel for Legend container for a consistent look
  • Fix z-index issues with menus (select dropdown menus, context menu, etc)
  • Update style of old Select menu to match context menu
  • Update Panel style a tiny bit

Validation

Before After
CleanShot 2025-02-03 at 11 47 57@2x CleanShot 2025-02-03 at 11 46 37@2x
CleanShot 2025-02-03 at 11 48 02@2x CleanShot 2025-02-03 at 11 47 05@2x

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review February 3, 2025 18:01
@andreachild
Copy link

LGTM

@kmcginnes kmcginnes merged commit a9c5600 into aws:main Feb 5, 2025
1 check passed
@kmcginnes kmcginnes deleted the theme-colors branch February 5, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants