Skip to content

Commit

Permalink
fix: generate non-overlapping artifacts (#1104)
Browse files Browse the repository at this point in the history
The @jsii/spec and jsii-spec packages would generate the same build
artifact, causing only one of them (jsii-spec) to be considered. This
ensures distinct artifact names are generated for each.
  • Loading branch information
RomainMuller authored and mergify[bot] committed Dec 8, 2019
1 parent ff1d017 commit 2add627
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
10 changes: 8 additions & 2 deletions tools/jsii-build-tools/bin/package-js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
#!/bin/bash
set -euo pipefail

rm -fr dist/js
mkdir -p dist/js
mv $(npm pack) dist/js

package_name=$(node -p "require('./package.json').name")
target_file="dist/js/${package_name/\//-}.tgz"

mkdir -p $(dirname ${target_file})

mv $(npm pack) ${target_file}
4 changes: 2 additions & 2 deletions tools/jsii-build-tools/bin/package-python
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ set -euo pipefail

rm -rf dist/python
mkdir -p dist/python
mv *.whl dist/python
mv *.tar.gz dist/python
cp *.whl dist/python
cp *.tar.gz dist/python

0 comments on commit 2add627

Please sign in to comment.