Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add reserved go words #2299

Closed
SoManyHs opened this issue Dec 2, 2020 · 1 comment · Fixed by #2300
Closed

chore: add reserved go words #2299

SoManyHs opened this issue Dec 2, 2020 · 1 comment · Fixed by #2300
Assignees
@SoManyHs

Comments

@SoManyHs
Copy link
Contributor

SoManyHs commented Dec 2, 2020

update https://github.com/aws/jsii/blob/main/docs/typescript-restrictions.md with reserved go words
@SoManyHs SoManyHs self-assigned this Dec 2, 2020
SoManyHs added a commit to SoManyHs/jsii that referenced this issue Dec 2, 2020
@SoManyHs
chore: add go reserved words
c27310c 
Fixes aws#2299
@SoManyHs SoManyHs mentioned this issue Dec 2, 2020
Merged
@mergify mergify bot closed this as completed in #2300 Dec 4, 2020
mergify bot pushed a commit that referenced this issue Dec 4, 2020
@SoManyHs
chore: add go reserved words (#2300)
2ef46d6 
Fixes #2299



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoManyHs SoManyHs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add go reserved words SoManyHs/jsii
1 participant
@SoManyHs