Skip to content

Commit

Permalink
added comments
Browse files Browse the repository at this point in the history
  • Loading branch information
njtran committed Mar 3, 2023
1 parent 6ff284f commit 6447bb1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions pkg/providers/amifamily/ami.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ func (p *Provider) fetchAMIsFromEC2(ctx context.Context, amiSelector map[string]
return amis.([]*ec2.Image), nil
}
describeImagesInput := &ec2.DescribeImagesInput{Owners: owners}
// Don't include filters in the Describe Images call as EC2 API doesn't allow empty filters.
if len(filters) != 0 {
describeImagesInput.Filters = filters
}
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/preview/concepts/node-templates.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ EC2 AMI IDs may be specified by using the key `aws::ids` (`aws-ids` is also supp
To ensure that AMIs are owned by the expected owner, use `aws::owners` which expects a comma-separated list of AWS account owners - you can use a combination of account aliases (e.g. `self` `amazon`, `your-aws-account-name`) and account IDs. If this is not set, *and* `aws::ids`/`aws-ids` are not set, it defaults to `self,amazon`.

{{% alert title="Note" color="primary" %}}
If you use only `aws::owners`, Karpenter will discover all images that are owned by those specified, selecting the most recently created ones to be used If you have very flexible requirements on your instance types, Karpenter may choose instance types that are incompatible with the images chosen. It is recommended to use `aws::name` if you're using `aws::owners`.
If you use only `aws::owners`, Karpenter will discover all images that are owned by those specified, selecting the most recently created ones to be used. If you specify `aws::owners`, but nothing else, there is a larger chance that Karpenter could select an image that is not compatible with your instance type. To lower this chance, it is recommended to use `aws::name` or `aws::ids` if you're using `aws::owners` to select a subset of images that you have validated are compatible with your selected instance types.
{{% /alert %}}

### AMI Selection
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v0.26.1/concepts/node-templates.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ EC2 AMI IDs may be specified by using the key `aws::ids` (`aws-ids` is also supp
To ensure that AMIs are owned by the expected owner, use `aws::owners` which expects a comma-separated list of AWS account owners - you can use a combination of account aliases (e.g. `self` `amazon`, `your-aws-account-name`) and account IDs. If this is not set, *and* `aws::ids`/`aws-ids` are not set, it defaults to `self,amazon`.

{{% alert title="Note" color="primary" %}}
If you use only `aws::owners`, Karpenter will discover all images that are owned by those specified, selecting the most recently created ones to be used If you have very flexible requirements on your instance types, Karpenter may choose instance types that are incompatible with the images chosen. It is recommended to use `aws::name` if you're using `aws::owners`.
If you use only `aws::owners`, Karpenter will discover all images that are owned by those specified, selecting the most recently created ones to be used. If you specify `aws::owners`, but nothing else, there is a larger chance that Karpenter could select an image that is not compatible with your instance type. To lower this chance, it is recommended to use `aws::name` or `aws::ids` if you're using `aws::owners` to select a subset of images that you have validated are compatible with your selected instance types.
{{% /alert %}}

### AMI Selection
Expand Down

0 comments on commit 6447bb1

Please sign in to comment.