Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move instance to providers #3509

Merged
merged 65 commits into from
Mar 6, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
7d31861
Moved launchtemplate to providers
engedaam Feb 22, 2023
2af2dc4
First round of fixing tests
engedaam Feb 23, 2023
08863ac
Merge branch 'main' of https://github.com/aws/karpenter into move-lau…
engedaam Feb 23, 2023
90b2094
Missing on Merge
engedaam Feb 23, 2023
b177bf1
adjustment to tests
engedaam Feb 23, 2023
5dd720b
Merge branch 'main' of https://github.com/aws/karpenter into move-lau…
engedaam Feb 23, 2023
3353793
Fix launchTemplateTest
engedaam Feb 24, 2023
a777a46
Merge branch 'main' of https://github.com/aws/karpenter into move-lau…
engedaam Feb 24, 2023
294d068
Feedback changes
engedaam Feb 24, 2023
a643327
Move Tests into Context
engedaam Feb 27, 2023
b588f1d
Merge branch 'main' of https://github.com/aws/karpenter into move-lau…
engedaam Feb 27, 2023
92a242e
Moved instancetypes to Provider
engedaam Feb 27, 2023
97f5242
Fix tests
engedaam Feb 27, 2023
33f2857
Feedback changes
engedaam Feb 27, 2023
2bea4fc
Merge branch 'move-launchTemplates-to-providers' of https://github.co…
engedaam Feb 27, 2023
5fb4201
Merge branch 'main' of https://github.com/aws/karpenter into Move-ins…
engedaam Feb 27, 2023
dcc1249
testing changes
engedaam Feb 27, 2023
6249e4b
Fixed all Tests
engedaam Feb 28, 2023
7ecc666
Hack File Updates
engedaam Feb 28, 2023
e51c1d4
Clean-up tests
engedaam Feb 28, 2023
4566f5e
Moved instances to providers
engedaam Feb 28, 2023
55ce622
Merge branch 'main' of https://github.com/aws/karpenter into Move-ins…
engedaam Feb 28, 2023
2d4bf16
Merge branch 'Move-instancetypes-to-providers' of https://github.com/…
engedaam Feb 28, 2023
598d5f6
Fixed tests
engedaam Feb 28, 2023
374f7c8
Merge branch 'Move-instancetypes-to-providers' of https://github.com/…
engedaam Feb 28, 2023
2cb8e62
Merge branch 'main' into Move-instancetypes-to-providers
engedaam Feb 28, 2023
dbb6b07
Merge branch 'main' into Move-instancetypes-to-providers
engedaam Mar 1, 2023
2323116
feedback changes
engedaam Mar 1, 2023
1d19027
feedback changes
engedaam Mar 1, 2023
11d0b15
Merge branch 'main' into Move-instancetypes-to-providers
engedaam Mar 1, 2023
792a624
Merge branch 'main' of https://github.com/aws/karpenter into Move-ins…
engedaam Mar 1, 2023
feab0d8
Merge branch 'Move-instancetypes-to-providers' of https://github.com/…
engedaam Mar 2, 2023
2af7d8f
merge missed test
engedaam Mar 2, 2023
b66b18d
Folder name change
engedaam Mar 2, 2023
98415d3
hack folder change
engedaam Mar 2, 2023
3fec83c
Missing changes
engedaam Mar 2, 2023
674cea7
file name change
engedaam Mar 2, 2023
02fc6f6
Merge branch 'main' into Move-instancetypes-to-providers
engedaam Mar 2, 2023
989e372
Merge branch 'Move-instancetypes-to-providers' of https://github.com/…
engedaam Mar 2, 2023
bf724d7
Merge branch 'main' of https://github.com/aws/karpenter into Move-ins…
engedaam Mar 2, 2023
7abf98b
Merge branch 'main' into Move-instance-to-providers
engedaam Mar 2, 2023
67bc738
Merge branch 'main' into Move-instance-to-providers
engedaam Mar 2, 2023
46e0e28
feedback changes
engedaam Mar 2, 2023
216647b
Added test.context
engedaam Mar 2, 2023
63d5f3f
changes
engedaam Mar 3, 2023
da76fb5
adjusting tests
engedaam Mar 3, 2023
7d56ac7
Adjusting more tests
engedaam Mar 3, 2023
d61c1e4
Merge branch 'main' of https://github.com/aws/karpenter into Move-ins…
engedaam Mar 3, 2023
b1e3e58
Only one failing test
engedaam Mar 3, 2023
edb0c3d
Fixed All tests
engedaam Mar 3, 2023
4322602
Merge branch 'main' into Move-instance-to-providers
engedaam Mar 3, 2023
763b0eb
One Failing test
engedaam Mar 3, 2023
596b35b
Fixed all tests
engedaam Mar 3, 2023
4dfbab2
cloudprovider params
engedaam Mar 3, 2023
95b1b98
Feedback changes
engedaam Mar 3, 2023
f7f7f46
Added environment for testing
engedaam Mar 6, 2023
a34fdea
Merge branch 'main' into Move-instance-to-providers
engedaam Mar 6, 2023
91a05c8
clean-up
engedaam Mar 6, 2023
64f4e76
Merge branch 'Move-instance-to-providers' of https://github.com/enged…
engedaam Mar 6, 2023
8d4dba6
fixing tests
engedaam Mar 6, 2023
f758354
name change
engedaam Mar 6, 2023
35bde79
Feedback changes
engedaam Mar 6, 2023
2325575
Removed cloudProvider from environment
engedaam Mar 6, 2023
3e14492
Feedback changes
engedaam Mar 6, 2023
e4e704e
Merge branch 'main' into Move-instance-to-providers
engedaam Mar 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cloudprovider/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ var _ = BeforeEach(func() {
})

cluster.Reset()
awsEnv.ResetCache()
awsEnv.Reset()

awsEnv.LaunchTemplateProvider.KubeDNSIP = net.ParseIP("10.0.100.10")
awsEnv.LaunchTemplateProvider.ClusterEndpoint = "https://test-cluster"
Expand Down
4 changes: 2 additions & 2 deletions pkg/controllers/machine/garbagecollect/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@ var _ = AfterSuite(func() {
})

var _ = BeforeEach(func() {
awsEnv.ResetCache()
awsEnv.Reset()
})

var _ = Describe("MachineGarbageCollect", func() {
var instance *ec2.Instance
var providerID string

BeforeEach(func() {
awsEnv.ResetCache()
awsEnv.Reset()
engedaam marked this conversation as resolved.
Show resolved Hide resolved
instanceID := fake.InstanceID()
providerID = fmt.Sprintf("aws:///test-zone-1a/%s", instanceID)
nodeTemplate := test.AWSNodeTemplate(v1alpha1.AWSNodeTemplateSpec{})
Expand Down
4 changes: 2 additions & 2 deletions pkg/controllers/machine/link/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ var _ = AfterSuite(func() {
})

var _ = BeforeEach(func() {
awsEnv.ResetCache()
awsEnv.Reset()
})

var _ = Describe("MachineLink", func() {
Expand All @@ -81,7 +81,7 @@ var _ = Describe("MachineLink", func() {
var nodeTemplate *v1alpha1.AWSNodeTemplate

BeforeEach(func() {
awsEnv.ResetCache()
awsEnv.Reset()
engedaam marked this conversation as resolved.
Show resolved Hide resolved
instanceID = fake.InstanceID()
providerID = fmt.Sprintf("aws:///test-zone-1a/%s", instanceID)
nodeTemplate = test.AWSNodeTemplate(v1alpha1.AWSNodeTemplateSpec{})
Expand Down
2 changes: 1 addition & 1 deletion pkg/controllers/nodetemplate/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ var _ = BeforeEach(func() {
},
}

awsEnv.ResetCache()
awsEnv.Reset()
})

var _ = AfterEach(func() {
Expand Down
6 changes: 0 additions & 6 deletions pkg/providers/amifamily/ami.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,3 @@ func (p *Provider) getRequirementsFromImage(ec2Image *ec2.Image) scheduling.Requ
requirements.Add(scheduling.NewRequirement(v1.LabelArchStable, v1.NodeSelectorOpIn, architecture))
return requirements
}

func (p *Provider) Reset() {
p.ssmCache.Flush()
p.ec2Cache.Flush()
p.kubernetesVersionCache.Flush()
}
2 changes: 1 addition & 1 deletion pkg/providers/instancetype/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ var _ = BeforeEach(func() {
})

cluster.Reset()
awsEnv.ResetCache()
awsEnv.Reset()

awsEnv.LaunchTemplateProvider.KubeDNSIP = net.ParseIP("10.0.100.10")
awsEnv.LaunchTemplateProvider.ClusterEndpoint = "https://test-cluster"
Expand Down
2 changes: 1 addition & 1 deletion pkg/providers/launchtemplate/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ var _ = BeforeEach(func() {
},
})
cluster.Reset()
awsEnv.ResetCache()
awsEnv.Reset()

awsEnv.LaunchTemplateProvider.KubeDNSIP = net.ParseIP("10.0.100.10")
awsEnv.LaunchTemplateProvider.ClusterEndpoint = "https://test-cluster"
Expand Down
2 changes: 1 addition & 1 deletion pkg/providers/pricing/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ var _ = BeforeEach(func() {
ctx = coresettings.ToContext(ctx, coretest.Settings())
ctx = settings.ToContext(ctx, test.Settings())

awsEnv.ResetCache()
awsEnv.Reset()
})

var _ = AfterEach(func() {
Expand Down
2 changes: 1 addition & 1 deletion pkg/providers/securitygroup/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ var _ = BeforeEach(func() {
},
})

awsEnv.ResetCache()
awsEnv.Reset()
})

var _ = AfterEach(func() {
Expand Down
2 changes: 1 addition & 1 deletion pkg/providers/subnet/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ var _ = BeforeEach(func() {
},
})

awsEnv.ResetCache()
awsEnv.Reset()
})

var _ = AfterEach(func() {
Expand Down
4 changes: 2 additions & 2 deletions pkg/test/environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type Environment struct {
}

func NewEnvironment(ctx context.Context, env *coretest.Environment) *Environment {
//
// API
ec2api := &fake.EC2API{}
ssmapi := &fake.SSMAPI{}

Expand Down Expand Up @@ -136,7 +136,7 @@ func NewEnvironment(ctx context.Context, env *coretest.Environment) *Environment
}
}

func (env *Environment) ResetCache() {
func (env *Environment) Reset() {
env.EC2API.Reset()
env.SSMAPI.Reset()
env.PricingAPI.Reset()
Expand Down