Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add eks:eks-cluster-name tag and remove karpenter.sh/managed-by annotation #6589

Merged
merged 12 commits into from
Jul 30, 2024
Merged

feat: Add eks:eks-cluster-name tag and remove karpenter.sh/managed-by annotation #6589

merged 12 commits into from
Jul 30, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Jul 25, 2024

Fixes #N/A

Description
Dropping karpenter.sh/managed-by as it is an artifact of a migration path and not something needed in the future. Adding eks:eks-cluster-name to support pod identity sessions.

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Jul 25, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4ea2e62
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66a973723d6f5e00080363c4

@coveralls
Copy link

coveralls commented Jul 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10171105631

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 79.283%
Totals Coverage Status
Change from base Build 10170862835: -0.009%
Covered Lines: 5974
Relevant Lines: 7535
💛 - Coveralls

@rschalo rschalo marked this pull request as ready for review July 25, 2024 21:18
@rschalo rschalo requested a review from a team as a code owner July 25, 2024 21:18
@rschalo rschalo requested a review from jonathan-innis July 25, 2024 21:18
@rschalo rschalo enabled auto-merge (squash) July 25, 2024 21:22
jonathan-innis
jonathan-innis reviewed Jul 29, 2024
View reviewed changes
pkg/apis/v1/ec2nodeclass.go Outdated Show resolved Hide resolved
pkg/apis/v1/labels.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/labels.go Outdated Show resolved Hide resolved
pkg/cloudprovider/cloudprovider.go Outdated Show resolved Hide resolved
pkg/controllers/nodeclaim/garbagecollection/controller.go Outdated Show resolved Hide resolved
njtran
njtran previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

njtran
njtran approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rschalo rschalo merged commit a41bad8 into aws:main Jul 30, 2024
16 checks passed
@rschalo rschalo deleted the add-eks-cluster-name-tag branch July 30, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

@njtran njtran njtran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rschalo @coveralls @njtran @jonathan-innis