feat(chart): Improved default security context #7279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
stevehipwell
force-pushed
the
chart-security-context
branch
from
e211a98 to
0e90ebf
Compare
stevehipwell
force-pushed
the
chart-security-context
branch
from
0e90ebf to
dacfc30
Compare
|
@tzneal could you take a look at this please? |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
stevehipwell
force-pushed
the
chart-security-context
branch
from
dacfc30 to
5cc1c72
Compare
|
@jonathan-innis @tzneal could someone please take a look at this? |
stevehipwell
force-pushed
the
chart-security-context
branch
from
5cc1c72 to
be44880
Compare
|
@jonathan-innis @tzneal could someone please take a look at this? |
|
I'll take a look at this. |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
stevehipwell
force-pushed
the
chart-security-context
branch
from
be44880 to
144aa53
Compare
|
/not-stale |
Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell
force-pushed
the
chart-security-context
branch
from
144aa53 to
e351477
Compare
|
@saurav-agarwalla did you manage to take a look at this? |
|
@stevehipwell apologies for the delay, I started reviewing this but then got side-tracked with the holidays and other things. Planning to get back to it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This PR improves the default security context posture and adds support for setting container values which should be user defined.
How was this change tested?
The Helm chart was templated with the new values.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.