Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Separate validation for update #7575

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Chore: Separate validation for update #7575

merged 7 commits into from
Jan 10, 2025

Conversation

edibble21
Copy link
Contributor

Fixes #N/A

Description
Separate version validation for update
How was this change tested?
make presubmit
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 6431014
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/678161258dab5100085bfb52

@coveralls
Copy link

coveralls commented Jan 8, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12714774272

Details

  • 10 of 13 (76.92%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 65.134%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/providers/version/version.go 7 9 77.78%
Totals Coverage Status
Change from base Build 12714446365: 0.009%
Covered Lines: 5780
Relevant Lines: 8874
💛 - Coveralls

@edibble21 edibble21 marked this pull request as ready for review January 8, 2025 22:21
@edibble21 edibble21 requested a review from a team as a code owner January 8, 2025 22:21
@edibble21 edibble21 changed the title Separate validation for update Chore: Separate validation for update Jan 8, 2025
engedaam
engedaam reviewed Jan 10, 2025
View reviewed changes
pkg/test/environment.go Outdated Show resolved Hide resolved
engedaam
engedaam approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edibble21 edibble21 merged commit b631d9e into aws:main Jan 10, 2025
16 checks passed
jmdeal pushed a commit that referenced this pull request Jan 24, 2025
@edibble21 @jmdeal
Chore: Separate validation for update (#7575)
8f399a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@jonathan-innis jonathan-innis Awaiting requested review from jonathan-innis jonathan-innis is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edibble21 @coveralls @engedaam