Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix graceful-node-shutdown url reference #7605

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

AndriiOmelianenko
Copy link
Contributor

Fixes #N/A

Description

graceful-node-shutdown section does not longer exist on the "Nodes" page, but moved to separate "Node Shutdowns" page

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AndriiOmelianenko AndriiOmelianenko requested a review from a team as a code owner January 16, 2025 11:05
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 23b01e5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6788e7fc7602470008c598d6
😎 Deploy Preview https://deploy-preview-7605--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🚀

@engedaam engedaam enabled auto-merge (squash) January 16, 2025 18:29
@engedaam engedaam merged commit c24b634 into aws:main Jan 16, 2025
17 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12807545137

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.983%

Totals Coverage Status
Change from base Build 12777192606: 0.0%
Covered Lines: 5775
Relevant Lines: 8887

💛 - Coveralls

edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants