feat(s2n-quic-crypto): replace ring with aws-lc on non-windows #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/remove-ring
branch
from
4874179 to
4aa4047
Compare
camshaft
changed the title
WesleyRosenblum
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change removes ring for all platforms except windows. I tried to replace it on windows as well, but ran into issues where NASM is required to be installed, which is a dependency regression from ring. I've opened an issue to track a possible fix: aws/aws-lc#1477.
Testing:
The non-windows builds should continue to pass after the switch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.