test(s2n-quic-core): use a smaller length in the Kani test #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
commented
Feb 15, 2024
| // Reduce the length to 4 for Kani until | ||
| // https://github.com/model-checking/kani/issues/3030 is fixed | ||
| #[cfg(any(kani, miri))] | ||
| const LEN: usize = if cfg!(kani) { 4 } else { 32 }; |
There was a problem hiding this comment.
I just noticed that I inadvertently changed the length for MIRI as well from 16 to 32. Is that OK, or should I revert it?
There was a problem hiding this comment.
I guess we'll see if the CI job times out :)
There was a problem hiding this comment.
Ah it already went through. Looks ok to me! https://github.com/aws/s2n-quic/actions/runs/7922350014/job/21629765794?pr=2128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
This fixes the issue of Kani going out of memory in CI on the
inet::checksum::tests::differentialtest, e.g.https://github.com/aws/s2n-quic/actions/runs/7892365794/job/21538690964
Description of changes:
The current length used in the
inet::checksum::tests::differentialtest is 16, which causes Kani's latest version (v0.46.0) to run out of memory (see model-checking/kani#3030). Until this issue is fixed, reducing the length to 4 to allow a smaller unwinding depth to prevent the OOM issue.Call-outs:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.