-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tox: skip install stages are not skipping install #4591
Labels
Comments
9 tasks
jmahlik
added a commit
to StateFarmIns/sagemaker-python-sdk
that referenced
this issue
Apr 17, 2024
… needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes aws#4591
jmahlik
added a commit
to StateFarmIns/sagemaker-python-sdk
that referenced
this issue
Apr 22, 2024
… needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes aws#4591
jmahlik
added a commit
to StateFarmIns/sagemaker-python-sdk
that referenced
this issue
Apr 22, 2024
… needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes aws#4591
jmahlik
added a commit
to StateFarmIns/sagemaker-python-sdk
that referenced
this issue
Apr 22, 2024
… needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes aws#4591
liujiaorr
pushed a commit
that referenced
this issue
Apr 22, 2024
* change: adjust tox black stages to install from requirements file Also remove uneeded config in the command, it is now set in the pyproject.toml so IDE's and other tooling outside tox picks up the setting. * change: improve tox install times by not installing all deps when not needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes #4591 * change: bump twine version to 5.0.0 Twine 3.8.0 didn't include its dependencies. The tox stage happened to work from packaging being installed as a transitive. Ref: pypa/twine#894
malav-shastri
pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this issue
Jun 20, 2024
* change: adjust tox black stages to install from requirements file Also remove uneeded config in the command, it is now set in the pyproject.toml so IDE's and other tooling outside tox picks up the setting. * change: improve tox install times by not installing all deps when not needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes aws#4591 * change: bump twine version to 5.0.0 Twine 3.8.0 didn't include its dependencies. The tox stage happened to work from packaging being installed as a transitive. Ref: pypa/twine#894
jiapinw
pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this issue
Jun 25, 2024
* change: adjust tox black stages to install from requirements file Also remove uneeded config in the command, it is now set in the pyproject.toml so IDE's and other tooling outside tox picks up the setting. * change: improve tox install times by not installing all deps when not needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes aws#4591 * change: bump twine version to 5.0.0 Twine 3.8.0 didn't include its dependencies. The tox stage happened to work from packaging being installed as a transitive. Ref: pypa/twine#894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Some tox stages can skip the install of the entire testing stack. The current config is resulting in these stages installing the
.[test]
extra, so they are taking a lot longer than they should. Fixing should improve ci time significantly for the PR checks.Flake8 for instance takes about 1/7 if the time.
Current config -- results in
.[test]
being installed.After -- only installs the flake8 deps
Timings for an environment recreation. These timings are on windows, so they're a quite inflated. The relative time is important though. This is with everything in the local pip cache.
Notice the large amount of deps installed before the change
Before Change
Post change
To reproduce
Run the tox linting stages. On windows, it takes a few hours just making environments which is how I noticed this.
Expected behavior
Only install the needed deps
Screenshots or logs
n/a
System information
A description of your system. Please provide:
Additional context
I can submit a PR with changes.
The text was updated successfully, but these errors were encountered: