breaking: require framework_version, py_version for tensorflow #1580

metrizable · 2020-06-12T00:20:18Z

Issue #, if available: #1465

Description of changes:

changes include:

framework_version, py_version required for framework TensorFlow
framework_version, py_version required for framework TensorFlowModel
re-order of args: convention to follow entry_point, push args with defaults below
testing updates
doc updates

Testing done:

unit:

% tox --parallel 3 tests/unit
✔ OK black-format in 13.57 seconds
✔ OK flake8 in 24.793 seconds
✔ OK twine in 14.049 seconds
✔ OK pylint in 37.106 seconds
✔ OK doc8 in 19.171 seconds
✔ OK py36 in 41.295 seconds
✔ OK sphinx in 1 minute, 37.846 seconds
✔ OK py37 in 37.777 seconds
✔ OK py27 in 1 minute, 55.877 seconds

integs:

% export IGNORE_COVERAGE=- ; tox -e py37 -- -s -vv tests/integ/test_tuner.py -k _tf ; unset IGNORE_COVERAGE
...
tests/integ/test_tuner.py::test_tuning_tf_script_mode[1.15.2] Started hyperparameter tuning job with name: tune-tf-script-m-1591919001-d74c
....................................................!
PASSED
tests/integ/test_tuner.py::test_tuning_tf[1.15.2] SKIPPED
tests/integ/test_tuner.py::test_tuning_tf_vpc_multi[1.15.2] SKIPPED
tests/integ/test_tuner.py::test_tuning_tf_script_mode[2.2.0] Started hyperparameter tuning job with name: tune-tf-script-m-1591919286-6da1
...............................................................!
PASSED
...

% export IGNORE_COVERAGE=- ; tox -e py37 -- -s -vv tests/integ/test_tf.py -k "not ml.p2" ; unset IGNORE_COVERAGE
...
tests/integ/test_tf.py::test_mnist_with_checkpoint_config[1.15.2-ml.m4.xlarge]
...
2020-06-12 00:07:26 Completed - Training job completed
Training seconds: 134
Billable seconds: 134
PASSED
tests/integ/test_tf.py::test_mnist_distributed[1.15.2-ml.m4.xlarge]
...
2020-06-12 00:13:56 Completed - Training job completed
Training seconds: 386
Billable seconds: 386
PASSED
...

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to any/all clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…n-tensorflow

sagemaker-bot · 2020-06-12T00:29:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 99279ff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T00:29:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 04f1858
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T00:48:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 04f1858
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T00:49:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 99279ff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T01:14:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 99279ff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T01:16:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 04f1858
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T02:10:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 04f1858
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T05:24:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 255c629
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T05:44:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 255c629
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T05:47:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 255c629
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T06:11:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 255c629
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T07:22:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3c59518
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T07:40:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3c59518
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T07:44:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 3c59518
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T08:09:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3c59518
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T14:35:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 735c5ef
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T14:55:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 735c5ef
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T15:00:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 735c5ef
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T15:22:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 735c5ef
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

doc/frameworks/tensorflow/upgrade_from_legacy.rst

src/sagemaker/tensorflow/estimator.py

src/sagemaker/tensorflow/model.py

src/sagemaker/tensorflow/estimator.py

tests/integ/test_tf.py

tests/unit/__init__.py

tests/unit/sagemaker/tensorflow/test_estimator.py

sagemaker-bot · 2020-06-12T19:58:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 210247c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T20:17:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 210247c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T20:45:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 210247c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T21:27:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 210247c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tests/conftest.py

tests/integ/test_tuner.py

sagemaker-bot · 2020-06-12T22:48:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7ee405a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T23:07:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7ee405a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T23:09:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 7ee405a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-12T23:34:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7ee405a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* add modelID support to model builder InProcess model * fix format * import pkg only if model id is specified * fix format and remove unused imports * add inference_spec to triton inProcess mode * fix format * fix format using black * fix app.py * Implement stop_server for fast api, remove model_server param from in_process mode * fix tests and format * rebase * remove Inference spec support arg in DJL builder, add fastapi reqs to pyproject * make changes to not support JS in in_process mode * fix code style errors * fix flake8 warnings * fix tgi unit tests to build for TGI usecase instead of JS

metrizable added 2 commits June 11, 2020 16:38

breaking: require framework_version, py_version for tensorflow

99279ff

Merge remote-tracking branch 'aws/zwei' into require-framework-versio…

b1e59b8

…n-tensorflow

metrizable force-pushed the require-framework-version-tensorflow branch from 04f1858 to 255c629 Compare June 12, 2020 05:15

fix: py_version issues between tf_full and tf_serving

3c59518

metrizable force-pushed the require-framework-version-tensorflow branch from 255c629 to 3c59518 Compare June 12, 2020 07:13

fix: too careless removing fixtures and not testing all integs

735c5ef

laurenyu reviewed Jun 12, 2020

View reviewed changes

fix: updates based on PR feedback

210247c

laurenyu reviewed Jun 12, 2020

View reviewed changes

tests/conftest.py Show resolved Hide resolved

tests/conftest.py Outdated Show resolved Hide resolved

tests/conftest.py Outdated Show resolved Hide resolved

tests/integ/test_tuner.py Outdated Show resolved Hide resolved

tests/integ/test_tuner.py Outdated Show resolved Hide resolved

fix: updates based on pr feedback

7ee405a

laurenyu approved these changes Jun 12, 2020

View reviewed changes

metrizable merged commit dbdaf50 into aws:zwei Jun 12, 2020

metrizable deleted the require-framework-version-tensorflow branch June 13, 2020 00:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

breaking: require framework_version, py_version for tensorflow #1580

breaking: require framework_version, py_version for tensorflow #1580

metrizable commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

sagemaker-bot commented Jun 12, 2020

breaking: require framework_version, py_version for tensorflow #1580

breaking: require framework_version, py_version for tensorflow #1580

Conversation

metrizable commented Jun 12, 2020

Merge Checklist

General

Tests

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 12, 2020

AWS CodeBuild CI Report