infra: use fixture for Python version in PyTorch integ tests #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Jun 20, 2020
pintaoz-aws
pushed a commit
that referenced
this pull request
Dec 4, 2024
…nt (#1612) * Fix: move the functionality from latest_container_image to retrieve * address some comments from Gokul and add unit test * remove extra functions and rewrite the test * fix unit test * fix for other unit test * unit test fix * fix unit test: add one more condition * more unit tests fix * remove redundant files * remove the special condition and fix the unit test * add integ test for base_model_builder_deploy and remove print statement * add endpoint name for ipynb * solve the integ test --------- Co-authored-by: Chad Chiang <[email protected]> Co-authored-by: Gokul Anantha Narayanan <[email protected]>
pintaoz-aws
pushed a commit
that referenced
this pull request
Dec 4, 2024
…nt (#1612) * Fix: move the functionality from latest_container_image to retrieve * address some comments from Gokul and add unit test * remove extra functions and rewrite the test * fix unit test * fix for other unit test * unit test fix * fix unit test: add one more condition * more unit tests fix * remove redundant files * remove the special condition and fix the unit test * add integ test for base_model_builder_deploy and remove print statement * add endpoint name for ipynb * solve the integ test --------- Co-authored-by: Chad Chiang <[email protected]> Co-authored-by: Gokul Anantha Narayanan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1461 (follow-up to #1609)
Description of changes:
Because we no longer run our tests with Python 2, the
PYTHON_VERSIONconstant is less meaningful. Plus, our integ tests our for testing the Python SDK, not images, so it should be sufficient for us to just test on the latest framework/Python version combination. (The unit tests can still test every combination.)I chose to make top-level fixtures because the greater plan is to have the fixtures generated once #1464 is done.
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.