enable new release process #705
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
buildspec-release.yml
Outdated
| AWS_CONTAINER_CREDENTIALS_RELATIVE_URI= AWS_DEFAULT_REGION= | ||
| tox -e py27,py36 -- tests/unit | ||
|
|
||
| # consider running integration and tests |
There was a problem hiding this comment.
maybe the tests annotated with @canary_quick?
also, I think you mean "integration tests" not "integration and tests"?
CONTRIBUTING.md
Outdated
| |---------------|------------------------------------------------------------------------------------------------| | ||
| | `breaking` | Incompatible API changes. | | ||
| | `deprecation` | Deprecating an existing API or feature, or removing something that was previously deprecated. | | ||
| | `feature` | Adding a new feature. | |
There was a problem hiding this comment.
nit: can you line up the vertical lines?
CHANGELOG.md
Outdated
|
|
||
| * enable new release process | ||
| * Migrate content from workflow and pytorch readmes into sphinx project | ||
| * Propagate Tags from estimator to model, endpoint, and endpoint config |
There was a problem hiding this comment.
it feels a little weird to start applying this to commits that were made before the commit message prefixes were introduced
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| 8. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation. | ||
| 5. Use commit messages (and PR titles) that follow [these guidelines](#commit-message-guidelines). | ||
| 6. Send us a pull request, answering any default questions in the pull request interface. | ||
| 7. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation. |
There was a problem hiding this comment.
doesn't have to be this PR, but maybe we should use # for numbering so that we don't have to maintain the actual numbers
| 'test': ['tox', 'flake8', 'pytest', 'pytest-cov', 'pytest-xdist', | ||
| 'mock', 'tensorflow>=1.3.0', 'contextlib2', 'awslogs', 'pandas']}, | ||
| 'test': ['tox', 'flake8', 'pytest', 'pytest-cov', 'pytest-rerunfailures', | ||
| 'pytest-xdist', 'mock', 'tensorflow>=1.3.0', 'contextlib2', |
There was a problem hiding this comment.
I realize also not in context for this PR - should we be on TF 1.12?
Description of changes:
enable new release process
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.