Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master back onto develop #1685

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Merge master back onto develop #1685

merged 1 commit into from
Aug 14, 2020

Conversation

sriram-mv
Copy link
Contributor

Merging back from master to develop, to keep develop upto date. Looks like the large number of changes are just deleted examples.

Co-authored-by: Steve Brown [email protected]
Co-authored-by: jtaylor00 [email protected]
Co-authored-by: Jacob Fuss [email protected]
Co-authored-by: Alex Wood [email protected]
Co-authored-by: Tarun [email protected]

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* feat: add support for VPCEndpointIds in EndpointConfiguration

* fix: update formatting with black

* docs: update 2016-10-31.md

* docs: added api endpointconfiguration example

* docs: make example more generic

* fix: remove nested EndpointConfiguration types from output

* fix: only allow one EndpointConfiguration Type

* doc: update example to reflect only allowing one EndpointConfiguration
Type

* fix : missing UserPool properties (#1506) (#1581)

* fix: resource policy generation for {path+} (#1580)

* refactor: Remove 2016-10-31 examples

* update PR template

* adjust pr template

* Adding authorization scopes as list validation in ApiGatewayAuthorizer (v1 and v2). (#1670)

* Adding authorization scopes as list validation in ApiGatewayAuthorizer and ApiGatewayV2Authorizer.

* make black.

* Adding functional test for invalid auth scope.

* adding error condition for invalid test.

* removing test template file.

* feat: MSK event type support for AWS::Serverless::Function (#52)

Co-authored-by: Steve Brown <[email protected]>
Co-authored-by: jtaylor00 <[email protected]>
Co-authored-by: Jacob Fuss <[email protected]>
Co-authored-by: Alex Wood <[email protected]>
Co-authored-by: Tarun <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2020

Codecov Report

Merging #1685 into develop will decrease coverage by 0.02%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1685      +/-   ##
===========================================
- Coverage    94.12%   94.09%   -0.03%     
===========================================
  Files           86       86              
  Lines         5547     5423     -124     
  Branches      1167     1084      -83     
===========================================
- Hits          5221     5103     -118     
- Misses         146      148       +2     
+ Partials       180      172       -8     
Impacted Files Coverage Δ
samtranslator/model/cognito.py 85.71% <ø> (+10.71%) ⬆️
samtranslator/model/lambda_.py 93.10% <ø> (ø)
samtranslator/model/sam_resources.py 93.37% <ø> (ø)
samtranslator/model/api/api_generator.py 94.91% <87.50%> (-0.28%) ⬇️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/model/apigateway.py 97.12% <100.00%> (+0.02%) ⬆️
samtranslator/model/apigatewayv2.py 94.28% <100.00%> (+0.34%) ⬆️
samtranslator/model/eventsources/pull.py 83.33% <100.00%> (+1.05%) ⬆️
samtranslator/swagger/swagger.py 92.47% <100.00%> (-0.02%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85501ac...c96cda1. Read the comment docs.

@sriram-mv sriram-mv merged commit 02ec8bf into develop Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants