fix: remove square bracket around referred ip lists #1706
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1696
Description of changes:
Removed the code for adding extra square bracket for reference ip list. Before making this change, customer will get sam deploy error when they try to refer a ip list from SSM in attribute IpRangeWhitelist. The deploy error is caused by we adding extra square bracket around a reference ip list.
Description of how you validated changes:
After making the change, I run the sam-translate.py transfer my test sam template to a cloud formation template and then manually deploy the cloud formation template, it works.
Checklist:
make pr
passesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.