Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove square bracket around referred ip lists #1706

Closed
wants to merge 1 commit into from

Conversation

mingkun2020
Copy link
Contributor

@mingkun2020 mingkun2020 commented Sep 8, 2020

Issue #, if available:
#1696

Description of changes:
Removed the code for adding extra square bracket for reference ip list. Before making this change, customer will get sam deploy error when they try to refer a ip list from SSM in attribute IpRangeWhitelist. The deploy error is caused by we adding extra square bracket around a reference ip list.

Description of how you validated changes:
After making the change, I run the sam-translate.py transfer my test sam template to a cloud formation template and then manually deploy the cloud formation template, it works.
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mingkun2020 mingkun2020 requested a review from awood45 September 9, 2020 17:18
@mingkun2020 mingkun2020 changed the title remove square bracket around referred ip lists fix: remove square bracket around referred ip lists Sep 9, 2020
@mingkun2020 mingkun2020 requested a review from mndeveci September 9, 2020 19:59
@mingkun2020 mingkun2020 deleted the issue1696 branch August 17, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants