Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support VIRTUAL_HOST as Type for SourceAccessConfiguration for … #2080

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Jul 6, 2021

…MQ events (#76) (#2078)

Co-authored-by: Renato Valenzuela [email protected]

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #2080 (fc7b0fa) into develop (e7a1496) will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2080      +/-   ##
===========================================
+ Coverage    93.58%   94.03%   +0.44%     
===========================================
  Files           90       92       +2     
  Lines         6124     6284     +160     
  Branches      1260     1282      +22     
===========================================
+ Hits          5731     5909     +178     
+ Misses         183      172      -11     
+ Partials       210      203       -7     
Impacted Files Coverage Δ
samtranslator/model/apigateway.py 97.15% <ø> (ø)
samtranslator/model/sam_resources.py 91.26% <ø> (+0.03%) ⬆️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
samtranslator/metrics/metrics.py 100.00% <100.00%> (ø)
samtranslator/model/api/api_generator.py 94.39% <100.00%> (+0.03%) ⬆️
samtranslator/model/eventsources/pull.py 84.73% <100.00%> (+6.04%) ⬆️
samtranslator/translator/translator.py 97.22% <100.00%> (+0.03%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09677fc...fc7b0fa. Read the comment docs.

@mgrandis mgrandis merged commit 56715db into aws:develop Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants