-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support "Name" for AWS::Serverless::HttpApi #2492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2492 +/- ##
===========================================
+ Coverage 93.58% 94.43% +0.85%
===========================================
Files 90 97 +7
Lines 6124 7318 +1194
Branches 1260 1527 +267
===========================================
+ Hits 5731 6911 +1180
- Misses 183 196 +13
- Partials 210 211 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GavinZZ
approved these changes
Nov 16, 2022
hoffa
reviewed
Nov 16, 2022
hoffa
reviewed
Nov 16, 2022
hoffa
approved these changes
Nov 17, 2022
aahung
changed the title
Support "Name" for AWS::Serverless::HttpApi
feat: Support "Name" for AWS::Serverless::HttpApi
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1617
Description of changes:
Allow customer to specify
Name
for `AWS::Serverless::HttpApi, like the rest of serverless resource types:Why it is implemented like that?
A:
AWS::ApiGatewayV2::Api
cannot haveBody
andName
at the same time. As SAM-T will addBody
to theAWS::ApiGatewayV2::Api
, we can only set Name by updating the openapi definition (info -> title). Right now theinfo -> title
is by default!Ref: AWS::StackName
.Proposed documentation change:
Description of how you validated changes:
I took the translated template and deployed to my account (with stack name
http-api-test-3
):Checklist:
make pr
passesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.