Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add JSON formatter and format all JSON files in tests #2553

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Oct 18, 2022

Issue #, if available

Description of changes

Build our JSON formatter without prettier (node dependency)

...
reformatted tests/translator/output/aws-us-gov/version_deletion_policy_precedence.json
reformatted tests/translator/output/aws-us-gov/alexa_skill.json
reformatted tests/translator/output/aws-us-gov/connector_bucket_to_function.json
reformatted tests/translator/output/aws-us-gov/function_with_deployment_preference_multiple_combinations_conditions_with_passthrough.json
reformatted tests/feature_toggle/input/feature_toggle_config.json
1189 file(s) scanned.
1189 file(s) reformatted.

run it again:

./bin/json-format.py --check tests
1189 file(s) scanned.
0 file(s) need reformat.

Description of how you validated changes

Checklist

  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung requested review from GavinZZ and hoffa October 18, 2022 22:37
@aahung aahung marked this pull request as ready for review October 18, 2022 22:39
@aahung aahung requested a review from xazhao October 18, 2022 22:39
@aahung aahung force-pushed the format-without-prettier branch from a3d97c5 to 0b38385 Compare October 18, 2022 22:41
@aahung aahung force-pushed the format-without-prettier branch from 0b38385 to 1ee2739 Compare October 18, 2022 22:41
@aahung aahung changed the title Add JSON formatter and format all JSON files in tests chore: Add JSON formatter and format all JSON files in tests Oct 18, 2022
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@aahung aahung merged commit d658d45 into aws:develop Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants