Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mypy --strict for future code #2558

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Enable mypy --strict for future code #2558

merged 3 commits into from
Oct 21, 2022

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Oct 20, 2022

Description of changes

Use https://pypi.org/project/mypy-clean-slate/ to add ignore to all existing method. Enable mypy --strict so any future development must be typed.

Description of how you validated changes

Trying to create a function without type and make pr failed.
Trying to cast return to Any and make pr also failed.

Checklist

  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xazhao xazhao requested review from aahung and hoffa October 20, 2022 21:59
Copy link
Contributor

@hoffa hoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@aahung aahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for marking EVERY SINGLE ONE OF THEM 👍

@hoffa hoffa merged commit 49f8d5f into aws:develop Oct 21, 2022
@hoffa hoffa mentioned this pull request Dec 1, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants