Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Type improvements in http api generator #2586

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Nov 10, 2022

Issue #, if available

TYPES!

Description of changes

This also fixes an incorrect error message, see error_httpapi_mtls_configuration_invalid_type and comments for detail

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung force-pushed the happy-type-cleanup-20221101 branch from 0d21ae4 to bfdc7c0 Compare November 10, 2022 00:53
@aahung aahung requested review from xazhao, GavinZZ and hoffa November 10, 2022 00:53
@aahung aahung marked this pull request as ready for review November 10, 2022 00:53
@aahung aahung force-pushed the happy-type-cleanup-20221101 branch from bfdc7c0 to 8e93ea8 Compare November 10, 2022 01:13
@aahung aahung force-pushed the happy-type-cleanup-20221101 branch from 8e93ea8 to 89f8902 Compare November 10, 2022 01:20
Copy link
Contributor

@hoffa hoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@aahung aahung merged commit 5007437 into aws:develop Nov 14, 2022
@aahung aahung deleted the happy-type-cleanup-20221101 branch November 17, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants