Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor schema #2639

Merged
merged 4 commits into from
Nov 22, 2022
Merged

chore: refactor schema #2639

merged 4 commits into from
Nov 22, 2022

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Nov 22, 2022

Issue #, if available

#1133

Description of changes

Puts each resource in its own file. Also fixed some issues with Api schema (union at wrong granularity).

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa requested a review from a team as a code owner November 22, 2022 02:53
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow nice! I love the refactor! Much cleaner to find each resource's schema.

.pylintrc Outdated Show resolved Hide resolved
@hoffa hoffa enabled auto-merge (squash) November 22, 2022 17:52
@hoffa hoffa merged commit bf01e52 into aws:develop Nov 22, 2022
@hoffa hoffa deleted the type-globals branch November 22, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants