fix: Allow Qualifier to be defined with Id in Serverless Connectors #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahung
reviewed
Jan 5, 2023
GavinZZ
approved these changes
Jan 5, 2023
xazhao
reviewed
Jan 5, 2023
awood45
requested changes
Jan 5, 2023
aahung
approved these changes
Jan 6, 2023
xazhao
approved these changes
Jan 6, 2023
awood45
approved these changes
Jan 6, 2023
aaythapa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
Right now if a user defines a Source of a connector using 'Id' then they can't add any other ResourceReference properties since most of the properties can be inferred if you have the ID. 'Qualifier' isn't one of them so users should be able to combine 'Id' and 'Qualifier'.
This change is also necessary for embedded connectors since the Source will defined using 'Id' and we want users to be able to define 'Qualifiers' in the embedded connectors.
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.