Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Batch update dev dependencies #2936

Merged
merged 6 commits into from
Feb 24, 2023
Merged

chore: Batch update dev dependencies #2936

merged 6 commits into from
Feb 24, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Feb 23, 2023

Issue #, if available

Description of changes

ruff adds a new rule that catches these:

bin/parse_docs.py:95:13: PLW2901 Outer for loop variable `description` overwritten by inner assignment target
bin/parse_docs.py:96:13: PLW2901 Outer for loop variable `description` overwritten by inner assignment target
bin/parse_docs.py:102:13: PLW2901 Outer for loop variable `description` overwritten by inner assignment target
samtranslator/model/api/api_generator.py:524:17: PLW2901 Outer for loop variable `basepath` overwritten by inner assignment target
samtranslator/model/api/http_api_generator.py:405:17: PLW2901 Outer for loop variable `path` overwritten by inner assignment target
samtranslator/open_api/open_api.py:222:21: PLW2901 Outer for loop variable `param` overwritten by inner assignment target
samtranslator/third_party/py27hash/hash.py:81:13: PLW2901 Outer for loop variable `y` overwritten by inner assignment target
samtranslator/translator/translator.py:331:21: PLW2901 Outer for loop variable `connector_logical_id` overwritten by inner assignment target
samtranslator/utils/py27hash_fix.py:412:17: PLW2901 Outer for loop variable `arg` overwritten by inner assignment target

Description of how you validated changes

make pr works

I tried to run a single integration test to see if pytest dependencies have breaking changes. Turns out fine:

(samtranslator37) ~/P/serverless-application-model ❯❯❯ pytest --no-cov integration/single/test_basic_function.py -k test_function_with_http_api_events                                                        ✘ 1 
=============================================================================================== test session starts ===============================================================================================
platform darwin -- Python 3.7.2, pytest-7.2.1, pluggy-0.13.1
rootdir: /Users/xinhol/Projects/serverless-application-model, configfile: pytest.ini
plugins: env-0.8.1, xdist-3.2.0, rerunfailures-11.1.1, cov-4.0.0, forked-1.3.0
collected 21 items / 19 deselected / 2 selected                                                                                                                                                                   

integration/single/test_basic_function.py::TestBasicFunction::test_function_with_http_api_events_0_single_function_with_http_api_events 
------------------------------------------------------------------------------------------------- live log setup --------------------------------------------------------------------------------------------------
INFO     botocore.credentials:credentials.py:1313 Found credentials in shared credentials file: ~/.aws/credentials
PASSED                                                                                                                                                                                                      [ 50%]
integration/single/test_basic_function.py::TestBasicFunction::test_function_with_http_api_events_1_single_function_alias_with_http_api_events 
-------------------------------------------------------------------------------------------------- live log call --------------------------------------------------------------------------------------------------
WARNING  samtranslator.metrics.metrics:metrics.py:135 There are unpublished metrics. Please make sure you call publish after you record all metrics.
PASSED                                                                                                                                                                                                      [100%]

================================================================================== 2 passed, 19 deselected in 196.64s (0:03:16) ===================================================================================

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung marked this pull request as ready for review February 23, 2023 23:30
@aahung aahung requested a review from a team as a code owner February 23, 2023 23:30
@aahung aahung enabled auto-merge (squash) February 23, 2023 23:31
@aahung aahung disabled auto-merge February 24, 2023 00:00
@aahung aahung enabled auto-merge (squash) February 24, 2023 00:03
@aahung aahung merged commit a1aee5d into aws:develop Feb 24, 2023
@aahung aahung deleted the upgrade-dev branch February 24, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants