Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Exclude samtranslator.internal from interface scan #3027

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Mar 14, 2023

Issue #, if available

Description of changes

See #3026, an example of unnecessary workflow failure

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung requested a review from aaythapa March 14, 2023 21:40
@aahung aahung marked this pull request as ready for review March 14, 2023 21:40
@aahung aahung requested a review from a team as a code owner March 14, 2023 21:40
@aahung aahung enabled auto-merge March 14, 2023 21:43
Copy link
Contributor

@acristin acristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good; minor suggestion around UX that you're free to ignore or put off until later.

bin/public_interface.py Outdated Show resolved Hide resolved
bin/public_interface.py Outdated Show resolved Hide resolved
@aahung aahung added this pull request to the merge queue Mar 14, 2023
Merged via the queue into aws:develop with commit ff14dbb Mar 14, 2023
@aahung aahung deleted the exclude-internal branch March 14, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants