Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include section in DataSource logical id #3070

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

ssenchenko
Copy link
Contributor

Issue #, if available

Description of changes

After discussing previous PR #3061 we decided instead to add section name to the data source logical id and ask customers to use CFN logical ID instead of relying on SAM reference resolver which won't work in more complex intrinsic functions

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ssenchenko ssenchenko requested a review from a team as a code owner March 27, 2023 22:31
hoffa
hoffa previously approved these changes Mar 27, 2023
Copy link
Contributor

@xazhao xazhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the folder temp used for?

GavinZZ
GavinZZ previously approved these changes Mar 27, 2023
@ssenchenko ssenchenko dismissed stale reviews from GavinZZ and hoffa via 6ccbd27 March 27, 2023 23:12
@ssenchenko
Copy link
Contributor Author

What is the folder temp used for?

Committed by mistake. I've removed them

xazhao
xazhao previously approved these changes Mar 27, 2023
@ssenchenko ssenchenko merged commit 7cc7ac1 into aws:feat-appsync Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants