Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow Dynamic Reference in CodeUri Property if no / used #3472

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Dec 15, 2023

Issue #, if available

Description of changes

Allow dynamic reference as long as it doesn't include / in it.

Description of how you validated changes

All tests pass

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ force-pushed the fix_dynamic_ref_in_code branch from 9d41cd4 to 8219d82 Compare December 15, 2023 01:01
@GavinZZ GavinZZ marked this pull request as ready for review December 15, 2023 01:02
@GavinZZ GavinZZ requested a review from a team as a code owner December 15, 2023 01:02
@GavinZZ GavinZZ closed this Dec 15, 2023
@GavinZZ GavinZZ reopened this Dec 15, 2023
@GavinZZ GavinZZ enabled auto-merge (squash) December 15, 2023 01:07
auto-merge was automatically disabled December 15, 2023 01:27

Pull Request is not mergeable

@GavinZZ GavinZZ enabled auto-merge (squash) December 15, 2023 01:29
@GavinZZ GavinZZ merged commit 1a6b7bd into aws:develop Dec 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants